fix: allow hyphenated words in vec/hyde queries (#383)#384
Open
fix: allow hyphenated words in vec/hyde queries (#383)#384
Conversation
The validateSemanticQuery regex rejected any hyphen followed by a word character, blocking common compound words (real-time, multi-client, kebab-case identifiers like better-sqlite3). Tighten the check to only match negation syntax at token boundaries (start of string or after whitespace). See tobi#383 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validateSemanticQueryregex from/-\w/to/(^|\s)-[\w"]/so negation is only detected at token boundariesreal-time,multi-client,better-sqlite3,state-of-the-art) now pass validation-term,-"phrase") still correctly rejectedTest plan
validateSemanticQuerytests covering hyphenated acceptance + negation rejectionqmd query 'vec: long-lived daemon'passes validationFixes #383
🤖 Generated with my pal CC, Claude Code