Conversation
Owner
|
Thank you for the PR, I‘ll have a look! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
First of all, really excited to see this project and great work! I'm a big fan and user of
sqlglotso any speedup in the world of SQL parsing is music to my ears. Looking forward to potential python bindings.When trying out the benchmark I noticed you did not use the rust tokenizer for sqlglot (
sqlglot[rs]), I would suggest changing to those to give as fair comparison as possible. The difference is (geometric mean)~8xfaster to~7xfaster which is still really exciting.To:
link
Could not find any contributing guidelines, so let me know if you'd prefer a different approach, happy to adjust.
Thanks again for building this!