Skip to content

Comments

Use sqlglot[rs]#2

Merged
tobilg merged 1 commit intotobilg:mainfrom
erikmunkby:chore/sqlglot-rust-tokenzier
Feb 17, 2026
Merged

Use sqlglot[rs]#2
tobilg merged 1 commit intotobilg:mainfrom
erikmunkby:chore/sqlglot-rust-tokenzier

Conversation

@erikmunkby
Copy link
Contributor

Hi!

First of all, really excited to see this project and great work! I'm a big fan and user of sqlglot so any speedup in the world of SQL parsing is music to my ears. Looking forward to potential python bindings.

When trying out the benchmark I noticed you did not use the rust tokenizer for sqlglot (sqlglot[rs]), I would suggest changing to those to give as fair comparison as possible. The difference is (geometric mean) ~8x faster to ~7x faster which is still really exciting.

["uv", "run", "--with", "sqlglot", "python3", os.path.join(PROJECT_ROOT, "tools", "bench-compare", "bench_sqlglot.py")]

To:

["uv", "run", "--with", "sqlglot[rs]", "python3", os.path.join(PROJECT_ROOT, "tools", "bench-compare", "bench_sqlglot.py")]

link

Could not find any contributing guidelines, so let me know if you'd prefer a different approach, happy to adjust.

Thanks again for building this!

@tobilg
Copy link
Owner

tobilg commented Feb 16, 2026

Thank you for the PR, I‘ll have a look!

@tobilg tobilg merged commit 2093dc2 into tobilg:main Feb 17, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants