Skip to content

feat(optimizer)!: annotate type for Snowflake CHR function #5929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2025
Merged

feat(optimizer)!: annotate type for Snowflake CHR function #5929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30579d9
feat(optimizer)!: annotate type for Snowflake CHR function
fivetran-BradfordPaskewitz Sep 19, 2025
f59b6bf
Merge branch 'main' into brad/snowflake_chr
georgesittas Sep 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sqlglot/dialects/snowflake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,6 +540,7 @@ class Snowflake(Dialect):
exp.AIAgg,
exp.AIClassify,
exp.AISummarizeAgg,
exp.Chr,
exp.Collate,
exp.RegexpExtract,
exp.RegexpReplace,
Expand Down
1 change: 1 addition & 0 deletions tests/dialects/test_snowflake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ def test_snowflake(self):
"SELECT BASE64_DECODE_BINARY('SGVsbG8=', 'ABCDEFGHwxyz0123456789+/')"
)

self.validate_identity("SELECT CHR(8364)")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this test, we already test it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't seem like we test snowflake? it's fine for just this one

self.validate_identity("SELECT {*} FROM my_table")
self.validate_identity("SELECT {my_table.*} FROM my_table")
self.validate_identity("SELECT {* ILIKE 'col1%'} FROM my_table")
Expand Down
8 changes: 8 additions & 0 deletions tests/fixtures/optimizer/annotate_functions.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1583,6 +1583,14 @@ INT;
CHARINDEX('world', 'hello world', 1);
INT;

# dialect: snowflake
CHAR(65);
VARCHAR;

# dialect: snowflake
CHR(8364);
VARCHAR;

# dialect: snowflake
COLLATE('hello', 'utf8');
VARCHAR;
Expand Down