Fixed release CI to support python 3.10 building #16
Conversation
|
Hm that's weird, it passed when I ran it |
|
Looks like this is failing due to a package called traitlets. I'm guessing it posted an invalid update since the version it is trying to install is |
|
Fair enough, thanks for having a go. The 3.10 fix was roughly known to me, but it's tough - I don't really do any Python development myself any more, so keeping track of new Python versions is not something that happens naturally. I think at this point, it's probably time to drop Python 3.6 (and maybe 3.7 already). I was most interested in the ARM64 build. It's really unfortunate; setuptools is very opaque. Edit: The fusion with The traitlets thing is weird; I think the solution is to check in |
|
Closing this PR as it is no longer needed by me. |
Apologies for the extra formatting, I can undo that if necessary.
I tested this and it successfully built the 3.10 wheels. All I did was I updated the
setup-pythonaction to v4 (v1 was having issues finding the right versions) and used strings for the Python versions (3.10 as a number was trying to install 3.1 lol).I'm still working on trying to get arm64 building -- you are correct that it is not simple to get working but I think with enough tinkering I'll be able to get that to work. For now though, this at least fixes #14.By the way, I did get it to build for arm64. Had to convert the project to use cmake + cibuildwheel, and this is only for 3.9 and 3.10, but at least it built. If you want me to PR everything I added, I can try to either make a hybrid release workflow that only uses cmake and cibuildwheel for the arm version, or I could just use that setup for both. This of course would only be after the wheels are confirmed working, because I have no idea if they even work.