Skip to content

make: Add groups for building tabs #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

make: Add groups for building tabs #509

wants to merge 2 commits into from

Conversation

bradjc
Copy link
Contributor

@bradjc bradjc commented Aug 22, 2023

This adds new targets make tab-<group> EXAMPLE=x to the build system.

The groups are:

  • apollo3
  • clue
  • esp32
  • hail
  • hifive
  • msp432
  • nrf52
  • ot
  • rpi
  • stm

Each group would build a tab file with several TBFs targeting addresses likely to be valid on boards in that group.

Questions

  1. Are these groups the right groups?
  2. Where did imix go? I think it went with the nrf52. Is it better to duplicate? I'm not sure what happens to make tab then.

Todo

  • Update readme.

@brghena
Copy link
Contributor

brghena commented Aug 22, 2023

Wouldn't Imix match Hail?

@bradjc
Copy link
Contributor Author

bradjc commented Aug 22, 2023

Wouldn't Imix match Hail?

It should, we should change hail to use 0x40000 for apps. But then it too is part of nrf52...

@jrvanwhy jrvanwhy added the upkeep Indicates a PR is upkeep as defined by the code review policy. label Aug 22, 2023
@bradjc bradjc mentioned this pull request Sep 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
upkeep Indicates a PR is upkeep as defined by the code review policy.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bradjc @brghena @jrvanwhy