-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(editor): no need to sync local selection from awareness #10611
base: canary
Are you sure you want to change the base?
fix(editor): no need to sync local selection from awareness #10611
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## canary #10611 +/- ##
==========================================
- Coverage 54.21% 54.20% -0.01%
==========================================
Files 2342 2342
Lines 108600 108578 -22
Branches 18101 18092 -9
==========================================
- Hits 58874 58852 -22
- Misses 48389 48400 +11
+ Partials 1337 1326 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
1a506d5
to
5bf342c
Compare
7d26ea4
to
de172ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will break our selection design and needs further discussion offline.
1a1ef2b
to
d145366
Compare
Fix issue [BS-2751](https://linear.app/affine-design/issue/BS-2751). Before:  After: 
d145366
to
51af10d
Compare
Cycle detected
.