Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): no need to sync local selection from awareness #10611

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Mar 4, 2025

  1. Local selection should be set directly without syncing from awareness.
  2. Fixed an error in the selection signal: Cycle detected.

Copy link
Contributor Author

fundon commented Mar 4, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 54.76190% with 19 lines in your changes missing coverage. Please review.

Project coverage is 54.20%. Comparing base (3d2c4fe) to head (51af10d).

Files with missing lines Patch % Lines
...ore/src/extension/selection/selection-extension.ts 50.00% 7 Missing and 2 partials ⚠️
...ite/affine/block-table/src/selection-controller.ts 0.00% 3 Missing ⚠️
...uite/affine/block-paragraph/src/paragraph-block.ts 60.00% 2 Missing ⚠️
...uite/affine/block-data-view/src/data-view-block.ts 50.00% 1 Missing ⚠️
...k-root/src/edgeless/edgeless-root-preview-block.ts 0.00% 1 Missing ⚠️
...ne/fragment-outline/src/body/outline-panel-body.ts 0.00% 1 Missing ⚠️
...work/block-std/src/view/element/block-component.ts 66.66% 1 Missing ⚠️
.../block-std/src/view/element/gfx-block-component.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary   #10611      +/-   ##
==========================================
- Coverage   54.21%   54.20%   -0.01%     
==========================================
  Files        2342     2342              
  Lines      108600   108578      -22     
  Branches    18101    18092       -9     
==========================================
- Hits        58874    58852      -22     
- Misses      48389    48400      +11     
+ Partials     1337     1326      -11     
Flag Coverage Δ
server-test 78.98% <ø> (-0.01%) ⬇️
unittest 30.94% <45.23%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fundon fundon force-pushed the fundon/03_04_no_need_to_sync_local_selection_from_awareness branch 8 times, most recently from 1a506d5 to 5bf342c Compare March 4, 2025 15:05
@fundon fundon marked this pull request as ready for review March 4, 2025 15:25
@fundon fundon requested a review from a team as a code owner March 4, 2025 15:25
@graphite-app graphite-app bot requested review from a team March 4, 2025 15:25
@fundon fundon force-pushed the fundon/03_04_no_need_to_sync_local_selection_from_awareness branch from 7d26ea4 to de172ed Compare March 4, 2025 15:28
Copy link
Contributor

@Saul-Mirone Saul-Mirone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break our selection design and needs further discussion offline.

@fundon fundon force-pushed the fundon/03_04_no_need_to_sync_local_selection_from_awareness branch 3 times, most recently from 1a1ef2b to d145366 Compare March 5, 2025 02:38
@fundon fundon force-pushed the fundon/03_04_no_need_to_sync_local_selection_from_awareness branch from d145366 to 51af10d Compare March 5, 2025 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants