-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
add icon & colors #12860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: canary
Are you sure you want to change the base?
add icon & colors #12860
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds several new icon and color assets, updates asset filenames, and refines UI component appearances on iOS. Key changes include:
- Addition of new icon assets (e.g., Web, Upload, Tools, etc.)
- Introduction of multiple themed color assets for dark/light modes
- Updates to UI elements in MainHeaderView and InputBox for improved consistency
Reviewed Changes
Copilot reviewed 40 out of 64 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
Icons.xcassets/* | Added new image sets with updated filenames for various icons |
Colors.xcassets/* | Introduced new color sets ensuring support for luminosity (dark/light) |
UIImage+Affine.swift, UIColor+Affine.swift | Added extensions to simplify icon and color usage in code |
MainHeaderView.swift, InputBox.swift | Updated UI components to use the new asset references and adjusted layout constraints |
project.pbxproj | Minor project format update |
Comments suppressed due to low confidence (4)
packages/frontend/apps/ios/App/Packages/Intelligents/Sources/Intelligents/Resources/Icons.xcassets/CheckCircle.imageset/Contents.json:4
- [nitpick] The filename 'Left icon.pdf' is misleading for an asset used as a CheckCircle icon. Consider renaming it to 'CheckCircle.pdf' to clearly match its usage.
"filename" : "Left icon.pdf",
packages/frontend/apps/ios/App/Packages/Intelligents/Sources/Intelligents/Resources/Icons.xcassets/Calendar.imageset/Contents.json:4
- [nitpick] The filename 'Left icon-1.pdf' does not clearly indicate that this asset represents a Calendar icon. Renaming it to 'Calendar.pdf' would improve clarity.
"filename" : "Left icon-1.pdf",
packages/frontend/apps/ios/App/Packages/Intelligents/Sources/Intelligents/Resources/Icons.xcassets/Box.imageset/Contents.json:4
- [nitpick] The filename 'Left icon-5.pdf' is ambiguous in the context of a Box icon. Consider using a name such as 'Box.pdf' for better clarity.
"filename" : "Left icon-5.pdf",
packages/frontend/apps/ios/App/Packages/Intelligents/Sources/Intelligents/Resources/Icons.xcassets/ArrowDown.imageset/Contents.json:4
- [nitpick] The filename 'More Options Icon.pdf' used for an ArrowDown asset may cause confusion. It is recommended to rename it to 'ArrowDown.pdf' so that the asset’s purpose is immediately clear.
"filename" : "More Options Icon.pdf",
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## canary #12860 +/- ##
==========================================
- Coverage 55.91% 55.62% -0.30%
==========================================
Files 2652 2652
Lines 125440 125440
Branches 19948 19884 -64
==========================================
- Hits 70142 69772 -370
- Misses 53550 53917 +367
- Partials 1748 1751 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e41fe59
to
0aa8d17
Compare
1c0c9fc
to
8d77c48
Compare
No description provided.