plotters: Adjust to new renderer handling in Matplotlib 3.6 #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The handling of the internal renderer objects changed in Matplotlib 3.6, and we haven't adjusted to the new API. Move the existing logic into a helper function so we can use it consistently, and try calling the new matplotlib API before falling back to the old logic. Fixes #291. Signed-off-by: Toke Høiland-Jørgensen <[email protected]>
tohojo
force-pushed
the
mpl-36-renderer-fixes
branch
from
27f126e
to
e4c5f65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The handling of the internal renderer objects changed in Matplotlib 3.6, and we
haven't adjusted to the new API. Move the existing logic into a helper function
so we can use it consistently, and try calling the new matplotlib API before
falling back to the old logic.
Fixes #291.