Skip to content

Extract the service name from a SPIFFE path #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Extract the service name from a SPIFFE path #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion service/websocketserver/setup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,8 @@ func (wss *WebSocketServer) handleWebSocket(w http.ResponseWriter, r *http.Reque
return
}

serviceName := strings.TrimPrefix(spiffeID.Path(), "/")
pathParts := strings.Split(spiffeID.Path(), "/")
serviceName := pathParts[len(pathParts)-1]
Comment on lines +113 to +114
Copy link
Member

@kchiranjewee63 kchiranjewee63 Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pathParts := strings.Split(spiffeID.Path(), "/")
serviceName := pathParts[len(pathParts)-1]
var serviceName string
if spiffeID.String() == wss.TokenetesSpiffeId.String() {
serviceName = common.TOKENETES_SERVICE_NAME
} else {
serviceName = extractServiceNameFromSPIFFEPath(spiffeID.Path())
}

And the function extractServiceNameFromSPIFFEPath can be:

  // extractServiceNameFromSPIFFEPath extracts the service name from a SPIFFE ID path.
  // For Kubernetes SPIFFE IDs, it looks for /sa/ pattern and extracts the service account name.
  // Falls back to the last path component if /sa/ pattern is not found.
  func extractServiceNameFromSPIFFEPath(path string) string {
      if saIndex := strings.Index(path, "/sa/"); saIndex != -1 {
          // Found /sa/ pattern, extract the service account name
          saStart := saIndex + 4 // skip "/sa/"
          pathAfterSA := path[saStart:]
          if nextSlash := strings.Index(pathAfterSA, "/"); nextSlash != -1 {
              return pathAfterSA[:nextSlash]
          }

          return pathAfterSA
      }

      // Fallback to last path component
      pathParts := strings.Split(path, "/")

      return pathParts[len(pathParts)-1]
  }


namespace := r.URL.Query().Get("namespace")
if namespace == "" {
Expand Down
Loading