A PR for Issue #25 ( Continuous Integration )

[JohannSuarez]

For issue #25

• Two new workflow files ( .github/workflows/mypy.yml and .github/workflows/pytest.yml )

• ./ganache.py now has "&" at the end for workflow to run it in the background.

• Pytest having issues with the config option "collect_ignore" in oceanprotocol/contracts/setup.cfg. I forked the contracts repo to remove the line. For now, the workflow clones my fork of the contracts repo.

• In tokenspice's README, regarding the instruction about running one test, that specified test doesn't exist anymore. So I edited the README to reference an existing test, and also added the workflow status badges. EDIT: BK's push seemed to have addressed this. I adjusted accordingly.

• In tokenspice.ini , ARTIFACTS_PATH now points to a user's relative directory instead of the absolute trentmc directory.

[trentmc]

Lots of progress, cool! Lmk when you would like me to review again. Best,

[JohannSuarez]

Good evening, Trent!

I removed the whitespace, and tokenspice.ini has been modified to your requested changes.
For the failing static type checks, I will need further guidance.

The static type checks have been failing by default even when using MyPy manually outside of this Github workflow. The result of this test is true to the current status of the TokenSPICE repo. I'll have to study more about MyPy and stubs before I can completely tackle the errors. This task could be big enough to be its own separate issue.

In the meantime, we can temporarily hide the MyPy badge from the README to hide the error status, and/or rig the static typechecking workflow to automatically pass.

[trentmc]

Re typechecks: yes let's hide it for now (as you've done) and then create a new issue for it (as you suggest).

Is the rest ready for review?

[JohannSuarez]

Okay, I have hidden the MyPy badge and set it to always pass.
Yes, I think everything is ready for review

[trentmc]

Most things look good. I run into a few errors when running mypy locally, see below. Could you fix please?

(venv) trentmc@trentmcLnv:~/code/tokenspice$ mypy --config-file mypy.ini ./
assets/agents/DataconsumerAgent.py:25: error: "DataconsumerAgent" has no attribute "_buyDT"
assets/agents/DataconsumerAgent.py:26: error: "DataconsumerAgent" has no attribute "_consumeDT"
engine/test/test_SimStateBase.py:15: error: Method must have at least one argument
engine/test/test_SimEngine.py:19: error: Method must have at least one argument
assets/agents/test/test_MinterAgents.py:5: error: Incompatible import of "AgentBase" (imported name has type Module, local name has type "Type[AgentBase]")
Found 5 errors in 4 files (checked 100 source files)

[JohannSuarez]

Hello, Trent! I have fixed all the errors that have been enumerated above.

Here's my log:

• engine/test/test_SimStateBase.py - A method had no arguments, so I applied the @staticmethod decorator.

• engine/test/test_SimEngine.py - A method had no arguments, so I also applied the @staticmethod decorator.

• assets/agents/DataconsumerAgent.py - There was an if-block that mentioned _buyDT and _consumeDT, neither of which have been defined anywhere, not even in the parent class. A ripgrep search shows these two methods are never mentioned anywhere else in the entire repo. I block commented it out, and left a message explaining why.

• assets/agents/test/test_MinterAgents.py - MyPy was complaining about the line from engine import AgentBase, which was odd considering dozens of other files have the exact same line. I simple reworded the line to import engine.AgentBase, made adjustments to the lines invoking it, and the error vanished.

These errors were actually what the MyPy workflow kept raising. Upon fixing these, the workflow now passes and so I have unhidden the MyPy badge.

[trentmc]

Looks good. Approving. Then I will merge.

Re DataconsumerAgent::_buyDT - something's up with that. So I just created #80 to fix it. The comment you inserted is appropriate for the meantime.