Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Sync for services #2473

Merged
merged 4 commits into from
Sep 28, 2024
Merged

Require Sync for services #2473

merged 4 commits into from
Sep 28, 2024

Conversation

davidpdrsn
Copy link
Member

@davidpdrsn davidpdrsn commented Dec 30, 2023

Fixes #1950

This will allow us to use Arc inside Router to make it cheaper to clone.

TODO

  • changelog

@davidpdrsn davidpdrsn added this to the 0.8 milestone Dec 30, 2023
clippy.toml Show resolved Hide resolved
@davidpdrsn davidpdrsn added the breaking change A PR that makes a breaking change. label Dec 30, 2023
@davidpdrsn davidpdrsn marked this pull request as ready for review December 30, 2023 21:35
Copy link
Member

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, diff doesn't even look that complicated ^^

axum/CHANGELOG.md Outdated Show resolved Hide resolved
@jplatte jplatte merged commit 52fd139 into main Sep 28, 2024
18 checks passed
@jplatte jplatte deleted the david/sync-services branch September 28, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change A PR that makes a breaking change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we require Sync for services?
4 participants