-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update prost to 0.13 #2829
base: main
Are you sure you want to change the base?
Update prost to 0.13 #2829
Conversation
There is an existing PR for this at #2825. |
Oh, sorry that's actually independent, just looked more closely 🤦🏼 |
Update Rust version to 1.70 to meet prost dependency requirements However, I'm not certain if this change is appropriate for axum-extra |
The CI doesn't seem to select the rust-version defined in individual crates though |
Feel free to just bump the MSRV defined in the workflow file. I don't think we'll be doing much more stuff for axum 0.7 anyways, and 0.8 will raise MSRV again. |
Great. I've updated the MSRV in the workflow file to 1.70 as suggested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I was wondering when the prost update might be included in a release? I completely understand if it's not possible to provide a specific timeline, but any general indication would be helpful for planning purposes on my end. |
This is likely to take at least another month, possibly many before it goes out. David hasn't been that active and I don't think it makes much sense to publish another breaking-change release of axum-extra before axum 0.8. |
This comment has been minimized.
This comment has been minimized.
@davidpdrsn could you take a look please, it's about bumping a new Prost version merci beaucoup |
Nobody is paid to work on axum, and priorities change. Also this is a breaking change and we haven't yet merged any breaking changes to There will likely be another set of releases, then we will start doing that. However, there's still a bunch of other things we want to do between merging this PR and releasing axum 0.8, axum-extra 0.10 (see the 0.8 milestone). |
No description provided.