Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prost to 0.13 #2829

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Update prost to 0.13 #2829

wants to merge 5 commits into from

Conversation

NOBLES5E
Copy link
Sponsor

No description provided.

@jplatte
Copy link
Member

jplatte commented Jul 10, 2024

There is an existing PR for this at #2825.

@jplatte jplatte closed this Jul 10, 2024
@jplatte jplatte reopened this Jul 10, 2024
@jplatte
Copy link
Member

jplatte commented Jul 10, 2024

Oh, sorry that's actually independent, just looked more closely 🤦🏼

@NOBLES5E
Copy link
Sponsor Author

Update Rust version to 1.70 to meet prost dependency requirements

However, I'm not certain if this change is appropriate for axum-extra

@NOBLES5E
Copy link
Sponsor Author

The CI doesn't seem to select the rust-version defined in individual crates though

@jplatte
Copy link
Member

jplatte commented Jul 10, 2024

Feel free to just bump the MSRV defined in the workflow file. I don't think we'll be doing much more stuff for axum 0.7 anyways, and 0.8 will raise MSRV again.

@NOBLES5E
Copy link
Sponsor Author

Great. I've updated the MSRV in the workflow file to 1.70 as suggested.

Copy link
Member

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jplatte jplatte added breaking change A PR that makes a breaking change. A-axum-extra labels Jul 11, 2024
@ksanfs
Copy link

ksanfs commented Jul 13, 2024

I was wondering when the prost update might be included in a release? I completely understand if it's not possible to provide a specific timeline, but any general indication would be helpful for planning purposes on my end.

@jplatte
Copy link
Member

jplatte commented Jul 13, 2024

This is likely to take at least another month, possibly many before it goes out. David hasn't been that active and I don't think it makes much sense to publish another breaking-change release of axum-extra before axum 0.8.

@realtimetodie

This comment has been minimized.

@realtimetodie
Copy link
Contributor

@davidpdrsn could you take a look please, it's about bumping a new Prost version merci beaucoup

@jplatte
Copy link
Member

jplatte commented Jul 22, 2024

Nobody is paid to work on axum, and priorities change. Also this is a breaking change and we haven't yet merged any breaking changes to main since 0.7.0.

There will likely be another set of releases, then we will start doing that. However, there's still a bunch of other things we want to do between merging this PR and releasing axum 0.8, axum-extra 0.10 (see the 0.8 milestone).

@realtimetodie

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-axum-extra breaking change A PR that makes a breaking change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants