Fixes: #2767 Update reqwest-response example #2852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
reviewed
Jul 29, 2024
There was a problem hiding this comment.
I think there was some sort of confusion in #2767. This example is currently showing how to stream a response from reqwest to a client, it's not showing how to actually proxy a request. The function name proxy_via_reqwest is misleading, but there is a separate example for proxying and I don't think it makes sense to show the same here.
Could you update this PR to only remove the response conversion boilerplate, and leave the request sending as-is? If you want, you can also rename the function to stream_reqwest_response.
This reverts commit 1901b80.
reqwest 0.12 updates its http dependency to 1.0, remove two conversion code: 1. StatuCode 1. Response http headers
|
Reconstruct code:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Update reqwest-response example, as explained by #2767 (comment)
Solution
Based on #2767 (comment)