Remove unneeded #[allow] attributes#2995
Merged
mladedav merged 2 commits intotokio-rs:mainfrom Oct 17, 2024
bengsparks:main
Merged
Remove unneeded #[allow] attributes#2995mladedav merged 2 commits intotokio-rs:mainfrom bengsparks:main
mladedav merged 2 commits intotokio-rs:mainfrom
bengsparks:main
Conversation
Backport to beta occurred in rust-lang/rust#129103 and stable never implemented this warning
mladedav
approved these changes
Oct 17, 2024
Collaborator
mladedav
left a comment
There was a problem hiding this comment.
Thanks for following up on this!
Member
|
I was a bit confused when seeing the PR title - I don't see the builtin |
jplatte
pushed a commit
that referenced
this pull request
Nov 14, 2024
Co-authored-by: Benjamin Sparks <b.sparks@alugha.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Cleanup from work done in #2904.
Solution
Remove all warning suppressions related to unreachable patterns, now that an exception for empty match arms has been made and backported to beta