chore: move docs from markdown files to rust source#3479
chore: move docs from markdown files to rust source#3479
Conversation
272445b to
617d661
Compare
617d661 to
9adff90
Compare
|
Thanks for taking care of this. I'll try to review in the next couple days. |
|
What is the best way to review this? Generating doc locally and comparing with the current version? |
|
That's a good question 😅 … there are some git diff settings for highlighting moved code, and for ignoring whitespace. That's probably what I would have tried. |
|
We may have waited long enough w/ finishing this that it won't be necessary anymore.. 😅 |
|
If it's fixed in rust analyzer and we close this, that's still the best case scenario I'd say. |
It's still IMHO nicer to read it as code than in a hover pane. I would advocate for accepting this over closing it even with the r-a change. To review that the docs are the same, perhaps use |
Closes #929
Motivation
Documentation created with
include_strdoes not show inrust-analyzertooltips. The issue is tracked byrust-analyzerbut there's no indication anyone would be able to work on it anytime soon.Solution
Move the documentation inline.
handlers_intro.mdanddebugging_handler_type_errors.mdwere used in two places so there is some duplication but not too much, one is 7 and the other 40 lines including empty lines.Interestingly, even clippy and rustdoc seems to not support
include_strfully as they do not warn on included docs the same way as they do on inline docs.