Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for recent kernels (up to 6.10) #296

Merged
merged 6 commits into from
Dec 28, 2024
Merged

Conversation

yaroslavros
Copy link
Contributor

Updated for new capabilities in kernels 6.8, 6.9, 6.10 including FixedFdInstall, FTruncate operations as well as bundled recv and send.
Added check for bundled send and recv feature flag (available from kernel 6.10).
Implemented tests accordingly.

…dFdInstall, FTruncate operations as well as bundled recv and send.

Added test for bundled send and recv feature flag (available from kernel 6.10).
Implemented tests accordingly.
@yaroslavros
Copy link
Contributor Author

Fixed formatting to keep rustfmt happy.

Not sure about "operation not permitted" in failing CI tests as they don't seem to indicate which specifically test failed - everything works fine on my machines. Is it a CI issue?
I see similar problem in few other PRs

@quininer
Copy link
Member

quininer commented Aug 8, 2024

This is a ci issue, but we don't have manpower to fix it at the moment.

src/opcode.rs Outdated Show resolved Hide resolved
src/opcode.rs Outdated Show resolved Hide resolved
Copy link

@vmingchen vmingchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! It would be nice to have this in. I am looking for the ftruncate support.

I have a question about IORING_RECV_MULTISHOT and some nits.

@vmingchen
Copy link

@yaroslavros Can you rebase and see if the CI issues are gone? Thanks!

Renamed FTruncate to Ftruncate for consistency.
@yaroslavros
Copy link
Contributor Author

@vmingchen I've synchronised my branch.

src/opcode.rs Outdated Show resolved Hide resolved
src/opcode.rs Show resolved Hide resolved
src/opcode.rs Outdated Show resolved Hide resolved
src/opcode.rs Outdated Show resolved Hide resolved
src/opcode.rs Outdated Show resolved Hide resolved
Copy link

@vmingchen vmingchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@quininer quininer merged commit b175a22 into tokio-rs:master Dec 28, 2024
12 checks passed
@quininer
Copy link
Member

Thank you!

@vmingchen
Copy link

Hi @quininer , would you please release a new version now that this PR has added several new APIs. I am personally interested in the new Ftruncate function. Thanks!

@quininer
Copy link
Member

@vmingchen done ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants