Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flesh out the std::sync::Arc mock implementation #14

Merged
merged 6 commits into from
Apr 21, 2019
Merged

Flesh out the std::sync::Arc mock implementation #14

merged 6 commits into from
Apr 21, 2019

Conversation

whentze
Copy link
Contributor

@whentze whentze commented Apr 18, 2019

This PR adds the following APIs to loom::sync::Arc<T>:

  • Arc::ptr_eq
  • Arc::strong_count
  • Default
  • From<T>

It also adds some basic docs (the current docs just say "TODO").

Unresolved questions:

  • Should we add support for weak refcounting?
  • Should we add some tests for this Arc?
  • How do we implement the methods that std uses fences for (try_unwrap etc.)?

seanmonstar
seanmonstar approved these changes Apr 19, 2019
View reviewed changes
Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@seanmonstar
Copy link
Member

Hm, seems a CI build got lost, there's nothing for me to "restart" it. Could you force push to trigger CI again?

@whentze
Copy link
Contributor Author

whentze commented Apr 19, 2019 •
edited
Loading

I triggered CI again, but it still gets stuck. I believe this is an instance of travis-ci/#10204, as #12 is stuck at the same check.

@carllerche
Copy link
Member

Fun fun... we should migrate to azure pipelines.

@carllerche
Copy link
Member

I tried restarting travis. If that doesn't work, I will force the merge.

@carllerche carllerche merged commit 981e6f6 into tokio-rs:master Apr 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@whentze @seanmonstar @carllerche