Skip to content

Conversation

@GlenDC
Copy link
Collaborator

@GlenDC GlenDC commented Jan 4, 2026

For rama we make use of prost to generate code, however it's pretty inconvient
that a user would need to add also prost or prost-types to their direct dependencies
in their cargo.toml given that it means they have to worry about it being compatible
with what rama uses and that kind of bookkeeping work.

And while you already have an option to support a custom path for both
the prost and prost-types crate, it seems there were a couple of locations
where ::prost was still hardcoded. Which makes me think that:

  • either I do something wrong
  • or that custom import path is not really verified/tested?

Anyhow, it's my first PR to this project so please do tell me if I'm off in the weeds with this one.

@GlenDC
Copy link
Collaborator Author

GlenDC commented Jan 4, 2026

FWIW, I am now declaring the prost dependencies from this exact branch, which unblocks me. So I can confirm that this was indeed the only missing pieces left to allow someone to be able to specify custom prost and prost-types import paths to allow you to run the project without having to add prost and prost-types as direct dependencies yourself.

For however much that verification is worth ofc.

@LucioFranco LucioFranco added this pull request to the merge queue Jan 10, 2026
Merged via the queue into tokio-rs:master with commit 33f8721 Jan 10, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants