WIP on tokio-compat macros.#16
Draft
yotamofek wants to merge 1 commit intotokio-rs:masterfrom
Draft
Conversation
|
Very interested in this, thanks for working on it! |
Author
|
@StanislavGlebik |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm opening a "draft" PR for this, because there are definitely some issues to address,
but wanted to show a POC for this.
Having
tokio-compatmacros that are orthogonal to thetokioones will make the transition story from 0.1 to 0.2 a little easier, I hope.Unfortunately, these are, for the time being, mostly copy-pasted from
tokio-macros(they have undergone some changes on latestmaster, but I'm sticking the version of the macros released withtokio 0.2.6). I tried anything I could think of to prevent this "ugly" duplication of code, but alas... couldn't find any reasonable method to do it. :(Some questions I'd like to ask the maintainers of this create before taking this PR out of draft status:
tokio-compatstory?tokio-compat-macros?tokio-macros-compat?Obviously this also needs a little documentation, but I wanted to get a general green-light before going down that path.
(Also - this is my first "real" contribution to the Rust ecosystem, would really love to be able to give some back to this amazing community.)