You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@taiki-e What do you think about adding feature flags to futures-core? I believe we (tokio) will only end up depending on the Stream trait and the ready macro.
AtomicWaker(futures_core::task::__internal::AtomicWaker) - This isn't a public API, it's intended for use with channels and utils, so it can be an option.
Spwan/LocalSpwan - I think many of the libraries that use futures-core don't use this (it is basically used only by the library that implements executors), so I think it's okay to have this as an option, but others may have different opinions.
FutureObj/LocalFutureObj - This is intended to be used in the Spwan/LocalSpwan traits or no_std. I think if Spwan can be an option this can be an option too (AFAIK this is basically not necessary if crates target only platforms that can use Box).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
futures-preview 0.3.0-alpha.17 has been released that includes rust-lang/futures-rs#1706, rust-lang/futures-rs#1708, rust-lang/futures-rs#1709, rust-lang/futures-rs#1662, and rust-lang/futures-rs#1602.
This will probably unblock #1244.
Solution
tokio-futuresto usefutures_core::readybecauseready!macro moved tofutures-corefromfutures-util(Move ready! macro to futures-core from futures-util rust-lang/futures-rs#1699). (I didn't do this in other crates becausefutures-coredependency is optional)