metrics: Stabilize active_task_count #6619
Open
+781
−757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
R-loom-current-thread
mox692
added
A-tokio
mox692
approved these changes
Jun 7, 2024
Darksonn
reviewed
Jun 7, 2024
|
Since #6114 has been merged, we need to resolve conflict here. |
rcoh
force-pushed
the
stabilize-active-tasks
branch
3 times, most recently
from
3542c59
to
0d087ef
Compare
Darksonn
reviewed
Jun 15, 2024
tokio/src/runtime/metrics/runtime.rs
Outdated
| /// | ||
| /// This value increases and decreases over time as tasks are spawned and as they are completed or cancelled. | ||
| /// | ||
| /// To see the total number of spawned tasks, see `spawned_tasks_count`. Note that this API currently requires using `--cfg tokio_unstable`. |
There was a problem hiding this comment.
If this is being stabilized, then the documentation should no longer say that it's unstable.
|
Ah that comment was attempting to refer to spawned_task_count
…On Sat, Jun 15, 2024, 3:06 PM Alice Ryhl ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tokio/src/runtime/metrics/runtime.rs
<#6619 (comment)>:
> @@ -47,6 +47,29 @@ impl RuntimeMetrics {
self.handle.inner.num_workers()
}
+ /// Returns the current number of active tasks in the runtime.
+ ///
+ /// This value increases and decreases over time as tasks are spawned and as they are completed or cancelled.
+ ///
+ /// To see the total number of spawned tasks, see `spawned_tasks_count`. Note that this API currently requires using `--cfg tokio_unstable`.
If this is being stabilized, then the documentation should no longer say
that it's unstable.
—
Reply to this email directly, view it on GitHub
<#6619 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADYKZZO5E3NIQNX465VC7LZHSGEFAVCNFSM6AAAAABI5FHB4SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMRQG44TGNZYHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Okay. It's a bit confusing like this. You don't need to say that it's unstable in the docs for other methods. |
1. stabilize `num_active_tasks` 2. Rename internal counters to match `num_active_tasks` 3. Split `rt_metrics` into `rt_metrics` and `rt_unstable_metrics`.
rcoh
force-pushed
the
stabilize-active-tasks
branch
from
0d087ef
to
c2b7d9a
Compare
|
I'm sorry for responding slowly here. I'm wondering whether the name should be something else. The word "active" is the opposite of "idle", but the count includes idle tasks that have not yet exited. How about a name like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Stabilize
num_active_tasksso it can be used outside of--cfg tokio_unstableSolution
num_active_tasksnum_active_tasksrt_metricsintort_metricsandrt_unstable_metrics.Refs: #6546