tests: pdfd-reaper: fix tests when '-' is absent from kernel version #6681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On my machine, any test that calls `is_pidfd_available` fails as my kernel string does not contain a '-'; the code expects there to be one. Fix the test so that is works regardless on whether the kernel string contains a '-'.
hexagonal-sun
force-pushed
the
pidfd-reaper-test-fix
branch
from
f4bf53a
to
6aba5a4
Compare
Darksonn
added
A-tokio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
On my machine, any pidfd reaper test that calls
is_pidfd_availablefails as my kernel version string does not contain a '-'; the code expects there to be one.Solution
Fix the test so that is works regardless on whether the kernel string contains a '-'.