Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update code according to MSRV change #6764

Merged
merged 5 commits into from
Aug 11, 2024
Merged

update code according to MSRV change #6764

merged 5 commits into from
Aug 11, 2024

Conversation

Vrtgs
Copy link
Contributor

@Vrtgs Vrtgs commented Aug 9, 2024

Motivation

there are a lot of things that are marked TODO that are waiting on MSRV that haven't been resolved

Solution

update the code according to todo comments

@github-actions github-actions bot added R-loom-current-thread Run loom current-thread tests on this PR R-loom-multi-thread Run loom multi-thread tests on this PR R-loom-multi-thread-alt Run loom multi-thread alt tests on this PR labels Aug 9, 2024
@Vrtgs
Copy link
Contributor Author

Vrtgs commented Aug 9, 2024

my bad I thought std::mem::size_of was added in the prelude of 1.70 😅, I was mistaken

@Darksonn Darksonn added the A-tokio Area: The main tokio crate label Aug 9, 2024
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Darksonn Darksonn merged commit 1781906 into tokio-rs:master Aug 11, 2024
86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate R-loom-current-thread Run loom current-thread tests on this PR R-loom-multi-thread Run loom multi-thread tests on this PR R-loom-multi-thread-alt Run loom multi-thread alt tests on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants