Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process: add Command::get_kill_on_drop() #7086

Merged
merged 2 commits into from
Jan 10, 2025
Merged

process: add Command::get_kill_on_drop() #7086

merged 2 commits into from
Jan 10, 2025
+20 −0

Conversation

czy-29
Copy link
Contributor

@czy-29 czy-29 commented Jan 10, 2025

Fixes: #7082

@Darksonn Darksonn added A-tokio Area: The main tokio crate M-process Module: tokio/process labels Jan 10, 2025
Darksonn
Darksonn reviewed Jan 10, 2025
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

tokio/src/process/mod.rs Outdated Show resolved Hide resolved
@Darksonn
Copy link
Contributor

You'll need to merge in master for CI to pass.

@czy-29
Copy link
Contributor Author

czy-29 commented Jan 10, 2025

You'll need to merge in master for CI to pass.

It seems that all the tests passed this time. 😄

Darksonn
Darksonn approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@Darksonn Darksonn merged commit 6bd3be2 into tokio-rs:master Jan 10, 2025
84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate M-process Module: tokio/process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add .get_kill_on_drop() method to Command
2 participants
@czy-29 @Darksonn