Repository navigation
rt: fix io_uring shutdown errors - #8634
Open
ThanhDodeurOdoo wants to merge 1 commit into
Open
ThanhDodeurOdoo wants to merge 1 commit into
ThanhDodeurOdoo wants to merge 1 commit into
Conversation
Contributor
Author
|
will write a test, just waiting for feedback before |
Darksonn
reviewed
Oct 13, 2026
Darksonn
left a comment
Member
There was a problem hiding this comment.
Thanks for catching this! Left two comments on the error handling in UringContext::drop — once those are addressed, please also go ahead and add a test in tokio/tests/fs_uring.rs.
ThanhDodeurOdoo
force-pushed
the
io-uring-shutdown-eintr
branch
3 times, most recently
from
October 14, 2026 04:35
571338d to
f744863
Compare
Contributor
Author
|
just added a test ( a FIFO to keep I/O pending). I checked that fails without the fix |
ThanhDodeurOdoo
marked this pull request as ready for review
October 14, 2026 04:39
Shutdown errors can leave operations pending. Panicking then drops operation resources that the kernel may still be using. Drain available completions before retrying EINTR, EBUSY or EAGAIN from shutdown waits. Also retry EINTR during submission . Before panicking on other shutdown errors, leak thé operation slab to keep pending buffers alive (same for submission flush failures).
ThanhDodeurOdoo
force-pushed
the
io-uring-shutdown-eintr
branch
from
October 15, 2026 01:34
f744863 to
c658c83
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shutdown errors can leave operations pending. Panicking then drops
operation resources that the kernel may still be using.
Drain available completions before retrying EINTR, EBUSY or EAGAIN
from shutdown waits. Also retry EINTR during submission .
Before panicking on other shutdown errors, leak thé operation slab
to keep pending buffers alive (same for submission
flush failures).