appender: add initial set of benches#2128
Merged
bryangarza merged 4 commits intotokio-rs:masterfrom May 23, 2022
Merged
Conversation
This patch adds blocking and nonblocking benchmarks. This code is from an old PR (tokio-rs#703) that was never merged, and now ported to TOT so that it compiles. Co-authored-by: Zeki Sherif <9832640+zekisherif@users.noreply.github.com>
Member
|
Ran the benchmarks locally: |
Member
|
Ran these benchmarks on a slower, but less noisy, VM. Under the theory that the writers here where benchmarking the allocator more than (The prior run was the PR's existing contents.) I'll flamegraph these benchmarks to confirm that it's allocator overhead, but I suspect that we'd want to change the writers to return only the buffer size to measure just |
Member
Author
|
Thanks. I need to look at why the Netlify build is failing... |
Member
|
same reason it was failing in Tokio: tokio-rs/tokio#4699 (comment). I'll fix this. |
davidbarsky
approved these changes
May 20, 2022
hawkw
pushed a commit
that referenced
this pull request
Jun 6, 2022
* appender: add initial set of benches This patch adds blocking and nonblocking benchmarks. This code is from an old PR (#703) that was never merged, and now ported to TOT so that it compiles. Co-authored-by: Zeki Sherif <9832640+zekisherif@users.noreply.github.com> * switch to no-op writers in benchmarks * fix macro resolution issue Co-authored-by: Zeki Sherif <9832640+zekisherif@users.noreply.github.com> Co-authored-by: David Barsky <me@davidbarsky.com>
hawkw
pushed a commit
that referenced
this pull request
Jun 7, 2022
* appender: add initial set of benches This patch adds blocking and nonblocking benchmarks. This code is from an old PR (#703) that was never merged, and now ported to TOT so that it compiles. Co-authored-by: Zeki Sherif <9832640+zekisherif@users.noreply.github.com> * switch to no-op writers in benchmarks * fix macro resolution issue Co-authored-by: Zeki Sherif <9832640+zekisherif@users.noreply.github.com> Co-authored-by: David Barsky <me@davidbarsky.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds blocking and nonblocking benchmarks. This code is from
an old PR (#703) that was never merged, and now ported to TOT so that it
compiles.
Co-authored-by: Zeki Sherif 9832640+zekisherif@users.noreply.github.com