Conversation
hawkw
left a comment
There was a problem hiding this comment.
Some changelog nits. Also, I usually try to make the PR numbers in the changelog Markdown links to that PR, can we do that here?
Thanks for working on this!
649b6ce to
1210f5c
Compare
Co-authored-by: Eliza Weisman <eliza@buoyant.io>
Co-authored-by: Eliza Weisman <eliza@buoyant.io>
Co-authored-by: Eliza Weisman <eliza@buoyant.io>
Co-authored-by: Eliza Weisman <eliza@buoyant.io>
Co-authored-by: Eliza Weisman <eliza@buoyant.io>
1210f5c to
734b7de
Compare
| [package] | ||
| name = "tracing-log" | ||
| version = "0.1.3" | ||
| version = "0.1.4" |
There was a problem hiding this comment.
this needs to be a breaking change release due to https://github.com/tokio-rs/tracing/pull/2740[)](https://github.com/tokio-rs/tracing/commit/e1a384648ad4ede609598662e48bb436f845fcdc)
| This release has a large number of changes to `tracing-appender`: | ||
|
|
||
| ### Added | ||
| - **non_blocking**: -Name spawned worker thread [#2219] |
There was a problem hiding this comment.
| - **non_blocking**: -Name spawned worker thread [#2219] | |
| - **non_blocking**: Name spawned worker thread [#2219] |
| - **non_blocking**: -Name spawned worker thread [#2219] | ||
| - **non_blocking**: Allow worker thread name to be configured [#2365] | ||
| - **rolling**: `RollingFileAppender::builder` for configuring `RollingFileAppender`s [#2227] | ||
| - **rolling**: `Builder::filename_suffix` method to configure the suffix for log files [#2225] | ||
| - **rolling**: `Builder::max_log_files` method to enable automatically deleting old log files [#2323] | ||
|
|
||
| ### Documented | ||
|
|
||
| - **rolling**: Clarify file appender docs [#2689] | ||
| - **rolling**: Fix typo in RollingFileAppender docs [#2375] |
There was a problem hiding this comment.
nit: can we put parens around the issue links as well, the way we do in the other changelog entries? sorry.
| - **non_blocking**: -Name spawned worker thread [#2219] | |
| - **non_blocking**: Allow worker thread name to be configured [#2365] | |
| - **rolling**: `RollingFileAppender::builder` for configuring `RollingFileAppender`s [#2227] | |
| - **rolling**: `Builder::filename_suffix` method to configure the suffix for log files [#2225] | |
| - **rolling**: `Builder::max_log_files` method to enable automatically deleting old log files [#2323] | |
| ### Documented | |
| - **rolling**: Clarify file appender docs [#2689] | |
| - **rolling**: Fix typo in RollingFileAppender docs [#2375] | |
| - **non_blocking**: -Name spawned worker thread ([#2219]) | |
| - **non_blocking**: Allow worker thread name to be configured ([#2365]) | |
| - **rolling**: `RollingFileAppender::builder` for configuring `RollingFileAppender`s ([#2227]) | |
| - **rolling**: `Builder::filename_suffix` method to configure the suffix for log files ([#2225]) | |
| - **rolling**: `Builder::max_log_files` method to enable automatically deleting old log files ([#2323]) | |
| ### Documented | |
| - **rolling**: Clarify file appender docs ([#2689]) | |
| - **rolling**: Fix typo in RollingFileAppender docs ([#2375]) |
| - bump minimum version of proc-macro2 to 1.0.60 [#2732] | ||
| - generate less dead code for async block return type hint [#2709] | ||
|
|
||
| ### Fixed | ||
|
|
||
| - fix instrument with "log" feature [#2599] |
There was a problem hiding this comment.
| - bump minimum version of proc-macro2 to 1.0.60 [#2732] | |
| - generate less dead code for async block return type hint [#2709] | |
| ### Fixed | |
| - fix instrument with "log" feature [#2599] | |
| - Bump minimum version of proc-macro2 to 1.0.60 ([#2732]) | |
| - Generate less dead code for async block return type hint ([#2709]) | |
| ### Fixed | |
| - Compilation error instrument with "log" feature ([#2599]) |
| - Fix typo in `field` docs [#2611] | ||
| - Remove duplicate wording [#2674] | ||
|
|
||
| ### Changed | ||
|
|
||
| - Allow `ValueSet`s of any length [#2508] |
There was a problem hiding this comment.
| - Fix typo in `field` docs [#2611] | |
| - Remove duplicate wording [#2674] | |
| ### Changed | |
| - Allow `ValueSet`s of any length [#2508] | |
| - Fix typo in `field` docs ([#2611]) | |
| - Remove duplicate wording ([#2674]) | |
| ### Changed | |
| - Allow `ValueSet`s of any length ([#2508]) |
| - Update env_logger to 0.10 from 0.7 to fix GHSA-g98v-hv3f-hcfr [#2740] | ||
|
|
||
| ### Fixed | ||
|
|
||
| - Fix minimal-versions correctness [#2246] |
There was a problem hiding this comment.
| - Update env_logger to 0.10 from 0.7 to fix GHSA-g98v-hv3f-hcfr [#2740] | |
| ### Fixed | |
| - Fix minimal-versions correctness [#2246] | |
| - Update env_logger to 0.10 from 0.7 to fix GHSA-g98v-hv3f-hcfr ([#2740]) | |
| ### Fixed | |
| - Fix minimal-versions correctness ([#2246]) |
| - **filter**: Implement `layer::Filter` for `Option<Filter>` [#2407] | ||
| - **fmt**: Add Chrono implementations for `FormatTime` [#2690] | ||
| - **fmt**: Support the `NO_COLOR` environment variable for determining whether `fmt::Layer` should emit ANSI color escape codes [#2647] | ||
| - **fmt**: make `format::Writer::new()` public [#2680] | ||
|
|
||
| ### Documented | ||
|
|
||
| - Document `registry` feature requirement for `fmt` feature [#2590] |
There was a problem hiding this comment.
| - **filter**: Implement `layer::Filter` for `Option<Filter>` [#2407] | |
| - **fmt**: Add Chrono implementations for `FormatTime` [#2690] | |
| - **fmt**: Support the `NO_COLOR` environment variable for determining whether `fmt::Layer` should emit ANSI color escape codes [#2647] | |
| - **fmt**: make `format::Writer::new()` public [#2680] | |
| ### Documented | |
| - Document `registry` feature requirement for `fmt` feature [#2590] | |
| - **filter**: Implement `layer::Filter` for `Option<Filter>` ([#2407]) | |
| - **fmt**: Add Chrono implementations for `FormatTime` ([#2690]) | |
| - **fmt**: Support the `NO_COLOR` environment variable for determining whether `fmt::Layer` should emit ANSI color escape codes ([#2647]) | |
| - **fmt**: make `format::Writer::new()` public ([#2680]) | |
| ### Documented | |
| - Document `registry` feature requirement for `fmt` feature ([#2590]) |
| - Allow constant field names in macros [#2617] | ||
| - Allow setting event names in macros [#2699] | ||
| - Allow `ValueSet`s of any length [#2508] | ||
|
|
||
| ### Fixed | ||
|
|
||
| - Use fully qualified names in macros for items exported from std prelude [#2621] | ||
|
|
||
| ### Documented | ||
|
|
||
| - Add `axum-insights` to relevant crates. [#2713] | ||
| - Fix link to RAI pattern crate documentation [#2612] | ||
| - Fix docs typos and warnings [#2581] | ||
| - Add `clippy-tracing` to related crates [#2628] | ||
| - Add `tracing-cloudwatch` to related crates [#2667] | ||
| - Fix deadlink to `tracing-etw` repo [#2602] | ||
|
|
There was a problem hiding this comment.
| - Allow constant field names in macros [#2617] | |
| - Allow setting event names in macros [#2699] | |
| - Allow `ValueSet`s of any length [#2508] | |
| ### Fixed | |
| - Use fully qualified names in macros for items exported from std prelude [#2621] | |
| ### Documented | |
| - Add `axum-insights` to relevant crates. [#2713] | |
| - Fix link to RAI pattern crate documentation [#2612] | |
| - Fix docs typos and warnings [#2581] | |
| - Add `clippy-tracing` to related crates [#2628] | |
| - Add `tracing-cloudwatch` to related crates [#2667] | |
| - Fix deadlink to `tracing-etw` repo [#2602] | |
| - Allow constant field names in macros [#2617] | |
| - Allow setting event names in macros [#2699] | |
| - Allow `ValueSet`s of any length [#2508] | |
| ### Fixed | |
| - Use fully qualified names in macros for items exported from std prelude [#2621] | |
| ### Documented | |
| - Add `axum-insights` to relevant crates. ([#2713]) | |
| - Fix link to RAI pattern crate documentation ([#2612]) | |
| - Fix docs typos and warnings ([#2581]) | |
| - Add `clippy-tracing` to related crates ([#2628]) | |
| - Add `tracing-cloudwatch` to related crates ([#2667]) | |
| - Fix deadlink to `tracing-etw` repo ([#2602]) | |
|
Thanks for your great work! Just want to ask if the process seems to be blocked. |
I'll get the remainder (tracing-subscriber, tracing-appender, etc.) out this week. I've been cherry-picking release PRs from this branch. |
|
i haven't been able to work on this too much as i've had COVID, unfortunately. @davidbarsky i think we'll need to update |
@hawkw yup! i was planning on bumping |
Co-authored-by: Eliza Weisman <eliza@buoyant.io>
|
Looking forward to the |
|
Any news? I'd be willing to help if it speeds up the process. |
Sorry, let me get #2791 updated. I'll close this PR in the meantime. |
Preparing a big release of stuff included (and not included...) in #2728. I'd like to tighten up some of the phrasing in the changelog before we land this, though.