attributes: make #[instrument] support string literal fields#2924
Open
svix-aaron1011 wants to merge 1 commit intotokio-rs:masterfrom
Open
attributes: make #[instrument] support string literal fields#2924svix-aaron1011 wants to merge 1 commit intotokio-rs:masterfrom
#[instrument] support string literal fields#2924svix-aaron1011 wants to merge 1 commit intotokio-rs:masterfrom
Conversation
The 'tracing::span!' macro supports passing in field names as string literals, which can be used to use an invalid Rust identifier as a field name (e.g. "type"). However, the 'instrument!' macro required that arguments to 'fields' be period-separated Rust identifiers. This commit extends the `#[instrument]` macro to support both period-separated identifiers and single string-literal fields. We preserve the original argument and pass it to the `tracing::span!` macro to preserve span/hygiene information.
Contributor
|
I found it weird that this would be required and checked why |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The 'tracing::span!' macro supports passing in field names as string literals, which can be used to use an invalid Rust identifier as a field name (e.g. "type"). However, the 'instrument!' macro required that arguments to 'fields' be period-separated Rust identifiers.
Solution
This commit extends the
#[instrument]macro to support both period-separated identifiers and single string-literal fields. We preserve the original argument and pass it to thetracing::span!macro to preserve span/hygiene information.Fixes #2438