Fix warnings about unexpected cfg(feature) values#2968
Merged
davidbarsky merged 4 commits intotokio-rs:masterfrom May 21, 2024
Merged
Fix warnings about unexpected cfg(feature) values#2968davidbarsky merged 4 commits intotokio-rs:masterfrom
davidbarsky merged 4 commits intotokio-rs:masterfrom
Conversation
The cfg for it was impossible to enable as of tokio-rs#441.
Previously, enabling this optional dependency did not do anything.
No need to use a custom cfg to run off-by-default tests.
It might be possible to make it work with tower_make instead, but that crate looks to be unmaintained (no longer present in the tower repo which is specified as the repository URL) so it should likely just be removed as a dependency.
Contributor
Author
Xiretza
reviewed
May 15, 2024
| } | ||
| } | ||
|
|
||
| #[cfg(feature = "tower-util")] |
There was a problem hiding this comment.
These could be migrated to tower_make instead, see #2971
Contributor
Author
There was a problem hiding this comment.
Yeah, see the commit description for why I didn't do that.
Contributor
Author
|
@davidbarsky any reason this wasn't merged after approval? |
Member
No reason other than "Phabricator taught me muscle memory that the PR author can land PRs/diffs after approval" 😅. Landing this. |
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
CI is failing due to a new rustc lint. More about this lint in the recent blog post.
Solution
See individual commits. I chose different solutions for different parts of the codebase where warnings were emitted.