Closed
Conversation
In the case of an event with a name and a parent, the change in #2083 to use a free function instead of a method for `is_enabled` was not applied. This particular variant was also not covered by any tests, which is how this error slipped through CI. This change fixes the `is_enabled` call and adds additional test coverage for this macros case. This change was originally submitted by @Mododo in #2983, but we have an issue where first-time contributor PRs to the `v0.1.x` branch don't trigger CI and we can't trigger it manually, so it needed to be recreated.
Contributor
Author
|
CI should go green once #3283 is merged. |
Contributor
Author
|
We got the CI to run on #2983 and it's now merged, so we don't need this PR now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In the case of an event with a name and a parent, the change in #2083
to use a free function instead of a method for
is_enabledwas notapplied. This particular variant was also not covered by any tests,
which is how this error slipped through CI.
Solution
This change fixes the
is_enabledcall and adds additional testcoverage for this macros case.
This change was originally submitted by @Mododo in #2983, but we have an
issue where first-time contributor PRs to the
v0.1.xbranch don'ttrigger CI and we can't trigger it manually, so it needed to be
recreated.