chore: fix warnings on nightly

tracing-attributes/src/lib.rs

@@ -58,6 +58,8 @@
     unused_parens,
     while_true
 )]
+// TODO: once `tracing` bumps its MSRV to 1.42, remove this allow.
+#![allow(unused)]
 extern crate proc_macro;
 
 use std::collections::HashSet;

tracing-subscriber/src/filter/env/mod.rs

@@ -406,20 +406,13 @@ impl From<env::VarError> for FromEnvError {
 impl fmt::Display for FromEnvError {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         match self.kind {
-            ErrorKind::Parse(ref p) => p.fmt(f),
-            ErrorKind::Env(ref e) => e.fmt(f),
+            ErrorKind::Parse(ref p) => write!(f, "{}", p.to_string()),
+            ErrorKind::Env(ref e) => write!(f, "{}", e.to_string()),
         }
     }
 }
 
 impl Error for FromEnvError {
-    fn description(&self) -> &str {
-        match self.kind {
-            ErrorKind::Parse(ref p) => p.description(),
-            ErrorKind::Env(ref e) => e.description(),
-        }
-    }
-
     fn source(&self) -> Option<&(dyn Error + 'static)> {
         match self.kind {
             ErrorKind::Parse(ref p) => Some(p),

tracing-subscriber/src/reload.rs

@@ -228,15 +228,12 @@ impl Error {
 
 impl fmt::Display for Error {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
-        error::Error::description(self).fmt(f)
-    }
-}
-
-impl error::Error for Error {
-    fn description(&self) -> &str {
-        match self.kind {
+        let msg = match self.kind {
             ErrorKind::SubscriberGone => "subscriber no longer exists",
             ErrorKind::Poisoned => "lock poisoned",
-        }
+        };
+        write!(f, "{}", msg)
     }
 }
+
+impl error::Error for Error {}