added more type hints

toluaina · Sep 25, 2021 · 21cd396 · 21cd396
1 parent c8b57fb
commit 21cd396
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 12 deletions.
diff --git a/pgsync/settings.py b/pgsync/settings.py
@@ -1,6 +1,7 @@
 """PGSync Settings."""
 import logging
 import logging.config
+from typing import Optional
 
 from environs import Env
 
@@ -98,11 +99,11 @@
 
 
 # Logging:
-def get_logging_config(silent_loggers=None):
+def _get_logging_config(silent_loggers: Optional[str] = None):
     """
     Return the python logging configuration based on environment variables.
     """
-    logging_config = {
+    config: dict = {
         "version": 1,
         "disable_existing_loggers": False,
         "formatters": {
@@ -131,19 +132,19 @@ def get_logging_config(silent_loggers=None):
     }
     if silent_loggers:
         for silent_logger in silent_loggers:
-            logging_config["loggers"][silent_logger] = {
+            config["loggers"][silent_logger] = {
                 "level": "INFO",
             }
 
     for logger_config in env.list("CUSTOM_LOGGING", default=[]):
         logger, level = logger_config.split("=")
-        logging_config["loggers"][logger] = {
+        config["loggers"][logger] = {
             "level": level,
         }
-    return logging_config
+    return config
 
 
-LOGGING = get_logging_config(
+LOGGING = _get_logging_config(
     silent_loggers=[
         "urllib3.connectionpool",
         "urllib3.util.retry",

diff --git a/pgsync/sync.py b/pgsync/sync.py
@@ -411,17 +411,17 @@ def _update(
             docs: List = []
             for payload in payloads:
                 payload_data: dict = self._payload_data(payload)
-                primary_values = [
+                primary_values: List = [
                     payload_data[key] for key in node.model.primary_keys
                 ]
-                primary_fields = dict(
+                primary_fields: dict = dict(
                     zip(node.model.primary_keys, primary_values)
                 )
                 filters[node.table].append(
                     {key: value for key, value in primary_fields.items()}
                 )
 
-                old_values = []
+                old_values: List = []
                 for key in root.model.primary_keys:
                     if key in payload.get("old").keys():
                         old_values.append(payload.get("old")[key])
@@ -434,7 +434,7 @@ def _update(
                     len(old_values) == len(new_values)
                     and old_values != new_values
                 ):
-                    doc = {
+                    doc: dict = {
                         "_id": self.get_doc_id(old_values),
                         "_index": self.index,
                         "_op_type": "delete",
@@ -457,10 +457,10 @@ def _update(
 
                 payload_data: dict = self._payload_data(payload)
 
-                primary_values = [
+                primary_values: List = [
                     payload_data[key] for key in node.model.primary_keys
                 ]
-                primary_fields = dict(
+                primary_fields: dict = dict(
                     zip(node.model.primary_keys, primary_values)
                 )