Create nodes at lines intersections #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A node is created at the intersection and the corresponding edges are split accordingly. Issue: tomalrussel/snkit#15 NB: the file `pyproject.toml` has beend added for testing with local dev files.
tomalrussell
reviewed
Jul 1, 2022
tomalrussell
reviewed
Jul 1, 2022
Tests for: - multiple intersections - partially overlapping lines - end-node intersection - already split network NOTE: overlapping lines test doesn't pass! Issue: tomalrussel/snkit#15
There is now a recursive function extracting the points from intersections, in an exhaustive way (excluding polygons). The crossing restriction has been removed because it is wrong for overlapping segments: the corresponding test now passes. A notable consequence is the change in handling endpoints: intersections with endpoints are now accepted. Issue: tomalrussel/snkit#15
tomalrussell
approved these changes
Jul 5, 2022
tomalrussell
reviewed
Jul 5, 2022
Special treatment of complex lines: - self-intersection points need to be found, no built-in way to do so - splitting a complex line at a self-intersecting point doesn't do what would be expected: a work around when splitting as well. NB: small fixes from @tomalrussel have been implemented
|
How do you usually handle the conflicts: should I rebase or merge my branch? Or you don't really care? |
|
Either is fine, thanks @jmon12! |
jmon12
commented
Jul 13, 2022
| intersection = [ | ||
| Point(p) for p, c in Counter(segments_coordinates).items() if c > 1 | ||
| ] | ||
| intersection = MultiPoint(intersection) |
There was a problem hiding this comment.
It might have sense to have a dedicated helper function here...
tomalrussell
added a commit
that referenced
this pull request
Aug 10, 2022
… main Merging #51 and dealing with conflicts.
|
Hi @jmon12 - apologies for leaving this hanging for a while - I've just fixed the conflicts and merged this in. I think it's in really useful shape, thanks for your work |
|
Hi @tomalrussell, I'm the one to be sorry! I was supposed to resolve the conflicts but was working on something else. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A node is created at the edges intersections and the corresponding edges are split accordingly.
This is an attempt to fix #15