Fix ValueError when type annotations don't match function parameters #758
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scripts using
cli.ExistingFileor other Predicate validators as type annotations crash withValueError: 'FileArgument' is not in listsince v1.10.Root Cause
In
_validate_args(), when processing type annotations fromtyping.get_type_hints(), the code assumes all annotation keys correspond to function parameters. In edge cases whereget_type_hints()returns extra annotations (e.g., from class-level annotations), callingargs_names.index(item)raisesValueError.Changes
plumbum/cli/application.py: Add check to skip annotations not in parameter listtests/test_cli_annotations.py: Addtest_extra_annotations_ignored()to validate fix with mockedget_type_hints()returning non-parameter annotationsOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.