Fix: SSH bug in windows #762
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
reviewed
Dec 31, 2025
tests/test_env.py
Outdated
| from plumbum._testtools import skip_on_windows | ||
|
|
||
| with contextlib.suppress(ModuleNotFoundError): | ||
| with contextlib.suppress(ModuleNotFoundError, ImportError): |
Collaborator
There was a problem hiding this comment.
Suggested change
| with contextlib.suppress(ModuleNotFoundError, ImportError): | |
| with contextlib.suppress(ImportError): |
ModuleNotFoundError is an ImportError
Not sure about the other change yet, just noting this quickly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
SshMachine, if we were to use windows specific path, it translates into something like/c/Users/...which isn't a compatible path for thescpcall in windows. I have changed the logic that calls the translation function to run only when the underlying platform isn't windows, which fixes the problem.Also, some basic test cases fix to prevent
ImportErrorwhen trying to getprintenv