Skip to content

Commit

Permalink
firecracker-microvm#4768: Don't check KVM in tools/devtool checkstyle
Browse files Browse the repository at this point in the history
Introducing a new flag, do_kvm_check, within cmd_test to manage cmd_checkstyle, allowing the bypass of KVM checks as outlined in the PR.

Signed-off-by: tommady <[email protected]>
  • Loading branch information
tommady committed Oct 23, 2024
1 parent 8c8ee32 commit 9f16d5b
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions tools/devtool
Original file line number Diff line number Diff line change
Expand Up @@ -661,6 +661,7 @@ unapply_performance_tweaks() {
cmd_test() {
do_ab_test=0
do_build=1
do_kvm_check=1
# Parse any command line args.
while [ $# -gt 0 ]; do
case "$1" in
Expand All @@ -682,6 +683,9 @@ cmd_test() {
"--no-build")
do_build=0
;;
"--no-kvm-check")
do_kvm_check=0
;;
"--") { shift; break; } ;;
*)
die "Unknown argument: $1. Please use --help for help."
Expand All @@ -691,7 +695,7 @@ cmd_test() {
done

# Check prerequisites.
ensure_kvm
[ $do_kvm_check != 0 ] && ensure_kvm
ensure_devctr
ensure_build_dir
ensure_ci_artifacts
Expand Down Expand Up @@ -907,7 +911,7 @@ cmd_mkdocs() {
}

cmd_checkstyle() {
cmd_test --no-build -- integration_tests/style -n 4 --dist worksteal
cmd_test --no-build --no-kvm-check -- integration_tests/style -n 4 --dist worksteal
}

# Check if able to run firecracker.
Expand Down

0 comments on commit 9f16d5b

Please sign in to comment.