Fix migration race #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
tommyengstrom
commented
Mar 19, 2024
tommyengstrom
commented
- Upgrade to lts-22.13
- Fix streamly code to use new interface
- Ensure a we use an exclusive lock during event migrations.
tommyengstrom
force-pushed
the
fix-migration-race
branch
from
91c5a2a to
79dd32a
Compare
EggBaconAndSpam
suggested changes
Mar 19, 2024
Comment on lines
+41
to
+45
| getEventStream ff = | ||
| Stream.bracketIO | ||
| (getEventList ff) | ||
| (const (pure ())) | ||
| Stream.fromList |
There was a problem hiding this comment.
Shouldn't this just be fromEffect?
As in, fromEffect (getEventList ff)
There was a problem hiding this comment.
Ok nvm, you are right.
Comment on lines
133
to
134
| -- Using stripesAndResources because the default is crazy: | ||
| -- "Set num resources to cores and crash if there are fewer stripes" |
There was a problem hiding this comment.
Could you add a link to scrive/pool#16 to add some context?
There was a problem hiding this comment.
Ah and the comment is backwards. It's 'set striped to num cores and crash if there are fewer resources than stripes'.
| S.unfoldrM | ||
| step | ||
| cursor | ||
| -- cursor <- liftIO $ Cursor.declareCursor conn (getPgQuery q) |
There was a problem hiding this comment.
any reason you want to leave the comment?
EggBaconAndSpam
approved these changes
Mar 19, 2024
Comment on lines
+41
to
+45
| getEventStream ff = | ||
| Stream.bracketIO | ||
| (getEventList ff) | ||
| (const (pure ())) | ||
| Stream.fromList |
There was a problem hiding this comment.
Ok nvm, you are right.
tommyengstrom
force-pushed
the
fix-migration-race
branch
from
5d1d176 to
b95c58b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.