Add .node mod support and refactor mod loader/manager; fix lexer/parser formatting and team index bug; add tests#3
Open
MonthZifang wants to merge 1 commit intotest-aifrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
internal/mods/loader.goand support.nodemods, including aliasing thegopackage import togomodand registering anodemanager.modLoglogger ininternal/mods/types.goand replace calls to the previousLogtarget withmodLogininternal/mods/manager.go, and delegate start/stop to the loader vialoader.Start()/loader.Stop()and collect loaded mods intom.modswithcollectLoadedModsLocked().Unloadto avoid unused variable and normalize JSON marshaling/unmarshaling field naming inloader.go.internal/mods/loader_test.gocovering loading of.jar,.js,.go,.node(case-insensitive) and disabled/unsupported scenarios.%vininternal/logic/lexer.goandinternal/logic/parser.goto avoid printing type values incorrectly.internal/render/render.goby usingintconversions for modulo and negative-index correction to avoidint32mixing.config.PersistConfiginstead ofpersist.Configinexamples/双核心集成示例.go.Testing
go test ./internal/mods -vwhich executedTestModLoaderLoadTypesandTestModLoaderDisabledAndUnsupportedand both tests passed.Codex Task