Skip to content

Conversation

@DanShaders
Copy link
Collaborator

@DanShaders DanShaders commented Nov 24, 2025

The only implemented control query is engine.validator.getActorTextStats. One can run it from inside a script via

actor_stats = await full_node.engine_console.get_actor_stats()

Adding support for more queries is as easy as adding them to a switch in is_engine_console_query in tonlib/tonlib/EngineConsoleClient.cpp and writing a wrapper in test/tontester/src/tonlib/engine_console.py.

@github-actions
Copy link

@codex review

@chatgpt-codex-connector
Copy link

To use Codex here, create a Codex account and connect to github.

Copy link
Collaborator Author

@DanShaders DanShaders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an ordinary self-review, nothing to see here.


namespace tonlib {

class ActorCounter {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Figure out if stopping a scheduler is fine when there are actors that are stopped but possibly not destroyed. If this is indeed fine, remove ActorCounter and just use std::atomic.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test?

return self._client

@property
def engine_console(self) -> EngineConsoleClient:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add usage to test_basic.py

@DanShaders
Copy link
Collaborator Author

DanShaders commented Nov 24, 2025

  • Extra ninja -C build install recompiles files because of git watcher

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

Findings:

  • tdutils/td/utils/MpscPollableQueue.h:27 now uses std::lock_guard/std::mutex, but the header still only includes <utility> and the old td/utils/SpinLock.h. Translation units that include this header directly (for example tonlib/test/online.cpp) will see 'std::mutex' was not declared' compile errors. Please add <mutex> (and drop the unused SpinLock include) so the header is self‑contained.
  • test/tonlib/test-ffi-event-loop.cpp:1-3 declares only <chrono>, <thread>, <vector> but later uses std::set (…#209). Without including <set> this test will fail to compile. Add the missing header alongside the other standard includes.
  • test/tonlib/test-ffi-awaitable.cpp:13-15 defines static constexpr Tag tags[2]; and immediately takes &tags[2] for continuation_1. Dereferencing the third element of a two-element array is undefined behaviour, even if the pointer is only used for identity comparisons. Use tags + 1 or &tags[1] to stay within bounds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant