Options runtime checks fix. #241
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`options` parameter is defined as optional in both `getSourceJsonUrl` and `getSourcesData`. However in implementation it is treated as if it guaranteed to be present and compile checks are overriden by `!!`. As a result, [example code](https://github.com/ton-community/contract-verifier-sdk/blob/main/example/node/index.ts) is guaranteed to fail at runtime.
tiaraton
approved these changes
Sep 12, 2024
tiaraton
approved these changes
Sep 12, 2024
MrG9090
approved these changes
Oct 22, 2024
MrG9090
approved these changes
Oct 27, 2024
MrG9090
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
optionsparameter is defined as optional in bothgetSourceJsonUrlandgetSourcesData.However in implementation it is treated as if it guaranteed to be present and compile checks are overriden by
!!.As a result, example code is guaranteed to fail at runtime.