Merged
Conversation
strohel
changed the title
Actor::started(), stopped() fallible
goodhoko
approved these changes
Aug 13, 2024
Member
goodhoko
left a comment
goodhoko
left a comment
There was a problem hiding this comment.
LGTM!
Let me rebase https://github.com/tonarino/portal/pull/3746 on top of this. It will get rid of quite some lines of expects.
strohel
force-pushed
the
error-reporting-qol
branch
from
d7b883a to
9c21aff
Compare
strohel
force-pushed
the
started-stopped-fallible
branch
from
9f02895 to
a88a4e7
Compare
strohel
force-pushed
the
error-reporting-qol
branch
from
9c21aff to
0e10b57
Compare
strohel
force-pushed
the
started-stopped-fallible
branch
from
a88a4e7 to
4eee983
Compare
strohel
force-pushed
the
error-reporting-qol
branch
from
0e10b57 to
30941a3
Compare
strohel
force-pushed
the
started-stopped-fallible
branch
2 times, most recently
from
8983ddb to
44575fd
Compare
strohel
force-pushed
the
started-stopped-fallible
branch
from
44575fd to
61f94b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've long time wanted to do this, other work on actor has finally triggered me.
This should allow removing almost all remaining occurrences of fallible
.unwrap()/.expect()in our downstream code.It is (obviously) semver-breaking change which causes a bit of churn to adapt to, but the fact of adapting itself should be a nice cleanup.