Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker enablement #67

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

TonyFleisher
Copy link

@TonyFleisher TonyFleisher commented Jan 31, 2022

Provides a framework for deploying the server in a docker environment

@TonyFleisher
Copy link
Author

A few notes:

  • docker-compose is not strictly necessary, it just provides a nice framework for handling the ports, volume, and environment settings. Since it is only one container, a similar effect could be reached using only the docker command passing these things via command line options.

  • That the intent of this is to build and run the docker image from source in a local environment.
    Another consideration would be to simplify things for servers that have internet connectively by publishing a docker images from the CI pipeline so that docker-compose (or docker) could be used without checking out the code.
    See: https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants