Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: arc api mode implementation #93

Merged
merged 26 commits into from
Jun 12, 2023
Merged

feat: arc api mode implementation #93

merged 26 commits into from
Jun 12, 2023

Conversation

wregulski
Copy link
Contributor

No description provided.

@mergify mergify bot assigned mrz1836 Jun 7, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 7, 2023

Welcome to our open-source project @wregulski! 💘

@mrz1836 mrz1836 added feature Any new significant addition refactor Any significant refactoring labels Jun 9, 2023
@mrz1836
Copy link
Member

mrz1836 commented Jun 9, 2023

@wregulski few more linter errors/issues

@wregulski
Copy link
Contributor Author

@wregulski few more linter errors/issues

@mrz1836 - I temporarily removed this unused code as it's referring to two test cases that needs to be adjusted.
I will take care of that in my first free slot.

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #93 (93d0727) into master (dad9131) will decrease coverage by 19.76%.
The diff coverage is 51.87%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #93       +/-   ##
===========================================
- Coverage   86.60%   66.85%   -19.76%     
===========================================
  Files          10       11        +1     
  Lines         627     1089      +462     
===========================================
+ Hits          543      728      +185     
- Misses         67      318      +251     
- Partials       17       43       +26     
Flag Coverage Δ
unittests 66.85% <51.87%> (-19.76%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
definitions.go 100.00% <ø> (ø)
err_definitions.go 0.00% <0.00%> (ø)
request.go 69.56% <0.00%> (-5.72%) ⬇️
submit_transactions.go 33.58% <27.77%> (-33.08%) ⬇️
submit_transaction.go 52.00% <48.03%> (-34.37%) ⬇️
policy_quote.go 62.09% <57.77%> (-29.34%) ⬇️
fee_quote.go 84.94% <59.25%> (-12.17%) ⬇️
query_transaction.go 57.34% <60.49%> (-7.05%) ⬇️
client.go 84.88% <68.68%> (-8.99%) ⬇️
best_quote.go 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dad9131...93d0727. Read the comment docs.

@mrz1836
Copy link
Member

mrz1836 commented Jun 12, 2023

Looks good @wregulski

However I am going to need to create v2 of Minercraft and merge this in there... I'll keep you posted.

@mrz1836 mrz1836 added the work-in-progress Used for denoting a WIP, stops auto-merge label Jun 12, 2023
@mrz1836 mrz1836 self-requested a review June 12, 2023 23:01
Copy link
Member

@mrz1836 mrz1836 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - going to make a v2

@mrz1836 mrz1836 removed the work-in-progress Used for denoting a WIP, stops auto-merge label Jun 12, 2023
@mrz1836 mrz1836 merged commit 91208a6 into tonicpow:master Jun 12, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Any new significant addition refactor Any significant refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants