feat: add production database connection to payload #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maneike
force-pushed
the
feat/add-prod-db-connection-to-payload
branch
from
802a490
to
9c27786
Compare
|
Check how I managed to resolve this issue in boring stack. Here's PR code https://github.com/tonik/boring-stack/pull/35/files |
maneike
force-pushed
the
feat/add-prod-db-connection-to-payload
branch
from
6d447de
to
93f7ef4
Compare
goszczynskip
reviewed
Nov 7, 2024
| }, | ||
| })`; | ||
|
|
||
| data = data.replace( |
There was a problem hiding this comment.
this place can produce errors if the payload changes the name for postgresAdapter.
Have you considered using a codemod here and replacing it via AST?
There was a problem hiding this comment.
This is a great idea! I think we should introduce codemods globally across the whole app when it comes to reading and writing files. This, however, will be done in a separate PR.
goszczynskip
reviewed
Nov 7, 2024
maneike
changed the title
maneike
force-pushed
the
feat/add-prod-db-connection-to-payload
branch
from
330c96d
to
d40ce80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces dynamic environments for Payload CMS, Vercel and local.