Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for loongarch64 #151

Merged
merged 1 commit into from
Feb 9, 2024
Merged

add support for loongarch64 #151

merged 1 commit into from
Feb 9, 2024

Conversation

yzewei
Copy link
Contributor

@yzewei yzewei commented Dec 2, 2023

I'm very sorry, due to my operational errors, the last PR failed, re -submitted to complete the Loongarch support work.
The LoongArch architecture (LoongArch) is an Instruction Set Architecture (ISA) that has a RISC style.
@crazy-max @tonistiigi

@tonistiigi
Copy link
Owner

Add testcases for this in https://github.com/tonistiigi/binfmt/blob/master/.github/workflows/ci.yml#L114-L132 as well.

@crazy-max Is there anything else that needs to be enabled for CI side?

@yzewei
Copy link
Contributor Author

yzewei commented Dec 20, 2023

Add testcases for this in https://github.com/tonistiigi/binfmt/blob/master/.github/workflows/ci.yml#L114-L132 as well.

@crazy-max Is there anything else that needs to be enabled for CI side?

Add debian image running test with the Loongarch architecture

@yzewei
Copy link
Contributor Author

yzewei commented Dec 20, 2023

@crazy-max Thanks!

@crazy-max
Copy link
Collaborator

@crazy-max Is there anything else that needs to be enabled for CI side?

I don't think so 👍

@crazy-max
Copy link
Collaborator

crazy-max commented Dec 20, 2023

Seems test fails for loong64: https://github.com/tonistiigi/binfmt/actions/runs/7271830266/job/19818345215?pr=151#step:6:138

uname: error while loading shared libraries: libc.so.6: cannot stat shared object: Error 38

I don't see linux/loong64 in the list of supported platforms either: https://github.com/tonistiigi/binfmt/actions/runs/7271830266/job/19818345215?pr=151#step:6:50

@yzewei
Copy link
Contributor Author

yzewei commented Dec 21, 2023

Seems test fails for loong64: https://github.com/tonistiigi/binfmt/actions/runs/7271830266/job/19818345215?pr=151#step:6:138

uname: error while loading shared libraries: libc.so.6: cannot stat shared object: Error 38

I don't see linux/loong64 in the list of supported platforms either: https://github.com/tonistiigi/binfmt/actions/runs/7271830266/job/19818345215?pr=151#step:6:50

Change the running test

There are some problems with the debian images libc.so under the cr.Loongnix.cn . After manual testing, the alpine image under the website can successfully output the uname -a

Or use yangzewei2023 can also complete the test

In order to unify, use yangzewei2023 here

Copy link
Collaborator

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazy-max crazy-max requested a review from tonistiigi December 21, 2023 10:45
@crazy-max
Copy link
Collaborator

@yzewei Can you squash your commits please?

@yzewei
Copy link
Contributor Author

yzewei commented Dec 22, 2023

@yzewei Can you squash your commits please?

OK

@yzewei yzewei requested a review from crazy-max December 22, 2023 02:01
@@ -34,6 +34,9 @@ if [ -z "$QEMU_TARGETS" ]; then
if [ "$arch" != "mips64" ] ; then
QEMU_TARGETS="$QEMU_TARGETS mips64-linux-user"
fi
if [ "$arch" != "loongarch64" ] ; then
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the GOARCH formatting, so should be loong64.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@crazy-max
Copy link
Collaborator

@yzewei I opened #153 to check qemu build and also adds missing tests in 82f3ca7

@yzewei
Copy link
Contributor Author

yzewei commented Dec 27, 2023

@yzewei I opened #153 to check qemu build and also adds missing tests in 82f3ca7

It looks like to adapt xx first

Signed-off-by: yzewei <[email protected]>
@tonistiigi tonistiigi merged commit 51a64e6 into tonistiigi:master Feb 9, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants