Conversation
…al_write=True Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Raise NotImplementedError for force_identical_write=True behaviour
raise Feb 23, 2026
NotImplementedError for force_identical_write=True on geospatial pin writes
Contributor
|
Woops, it looks like this wasn't actually necessary - it was already done. |
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
No data about coverage (81.60% Estimated after merge)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
force_identical_write=Trueis not yet implemented for geospatial pin types (GeoDataFrame,Raster). Passing it should raiseNotImplementedErrorrather than silently ignoring it or producing undefined behaviour.Changes
gpkg.py,parquet.py): Markforce_identical_writeas "Not supported." — consistent with the existingtif.pydocstringtest_gpkg.py,test_parquet.py,test_tif.py): Addtest_force_identical_write_raisesto each filetype, assertingNotImplementedErroris raised with a matching messageOriginal prompt
raise NotImplementedErrorforforce_identical_write=Truebehaviour #17💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.