Refactor response parsing in _parse_response to handle single and mul…#6
Merged
Refactor response parsing in _parse_response to handle single and mul…#6
Conversation
…tiple DocumentDetails objects
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the response parsing logic in the _parse_response function to handle both single DocumentDetails objects and lists of DocumentDetails objects more robustly. The change improves the function's ability to parse API responses that may return either a single document or multiple documents.
- Replaced hardcoded list processing with type-checking logic that handles both dict and list responses
- Added explicit handling for single document responses by wrapping them in a list for consistent return type
- Included fallback logic to return
Nonefor unexpected response formats
src/templafy/api/documents/get_libraries_space_id_documents_assets_asset_id.py
Show resolved
Hide resolved
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
No data about coverage (25.60% Estimated after merge)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tiple DocumentDetails objects