Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More valid schema value types. #204

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wbrown
Copy link

@wbrown wbrown commented Dec 25, 2016

This commit adds more schema value types, even though Datascript doesn't care about the type other than if it's a :db.type/ref or not. The value type keywords follow closely with Datomic.

This allows using a schema defined for Datascript to drive schemas for other databases that care more about type such as Datomic or ElasticSearch.

If it is preferred that :db.type/ref is the only valid type, we could instead have that refer to a def'ed value containing a set of :db.type/ref. This would allow monkey-patching by other modules by redefining the value.


This change is Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant