Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random Ball Location and Speed. Fix for #349 #398

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Harry-Hopkinson
Copy link
Contributor

For #349, generates a random number for the ball starting location and its velocity.

@codecov-commenter
Copy link

Codecov Report

Merging #398 (25d5a19) into master (56eee8f) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #398   +/-   ##
=======================================
  Coverage   17.08%   17.08%           
=======================================
  Files          21       21           
  Lines        1147     1147           
  Branches      154      154           
=======================================
  Hits          196      196           
  Misses        942      942           
  Partials        9        9           
Impacted Files Coverage Δ
src/panel/states.ts 16.56% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Harry-Hopkinson Harry-Hopkinson changed the title Random Ball Location and Speed. Random Ball Location and Speed. Fix for #349 Mar 28, 2023
@Harry-Hopkinson Harry-Hopkinson marked this pull request as draft March 30, 2023 19:10
@Harry-Hopkinson
Copy link
Contributor Author

There can be no parameters in the BallState class as all the values are randomly generated.

@Harry-Hopkinson Harry-Hopkinson marked this pull request as ready for review March 30, 2023 19:24
@Harry-Hopkinson
Copy link
Contributor Author

Harry-Hopkinson commented Mar 31, 2023

@tonybaloney this PR should be ready

@Harry-Hopkinson Harry-Hopkinson force-pushed the random-ball-location-and-speed branch from 5c30ded to 474a5ca Compare June 5, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants