Fix disappearing dialog in WSL #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #495 +/- ##
==========================================
+ Coverage 15.47% 16.85% +1.37%
==========================================
Files 20 22 +2
Lines 814 1163 +349
Branches 105 158 +53
==========================================
+ Hits 126 196 +70
- Misses 688 961 +273
- Partials 0 6 +6
☔ View full report in Codecov by Sentry. |
|
Releasing in 1.25.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is due to a race condition on a dangling promise that happens before the quick pick list. This awaits that one and adds a tslint check.
Fixes #487
Fixes #489
Fixes #494
Fixes #467